Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gtk_menu_popup_at_pointer for GTK 3.22+ in FmFolderView #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use gtk_menu_popup_at_pointer for GTK 3.22+ in FmFolderView #70

wants to merge 1 commit into from

Conversation

wb9688
Copy link
Contributor

@wb9688 wb9688 commented Feb 2, 2021 •
edited
Loading

gtk_menu_popup() has been deprecated in GTK 3.22 in favor of the new gtk_menu_popup_at_widget(), gtk_menu_popup_at_pointer(), and gtk_menu_popup_at_rect() due to Wayland.

@LStranger
Copy link
Member

While it looks good, does gtk_menu_popup_at_pointer() ensure menu is always inside of widget for which it was opened? I'm afraid it will not, especially if that was a keyboard stroke what pulled off the menu. The popup_position_func() ensured that so I suppose some logic should be created for 3.22+ to make a position for menu and gtk_menu_popup_at_widget() called instead.

@wb9688 wb9688 mentioned this pull request Feb 5, 2021
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wb9688 @LStranger